feat: Start working on a simple cross window RPC provider #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtera
force-pushed
the
feat/embedded-provider
branch
2 times, most recently
from
d289d18
to
1081c29
Compare
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
dzbo
reviewed
Oct 31, 2024
richtera
force-pushed
the
feat/embedded-provider
branch
from
d346c2c
to
bfd5810
Compare
dzbo
approved these changes
Oct 31, 2024
| @@ -10,3 +10,5 @@ | |||
| !.* | |||
| .eslintcache | |||
| /.vscode | |||
|
|
|||
| /packages/tools-lukso-provider/docs/**/*.md | |||
There was a problem hiding this comment.
Why don't we ignore the whole packages directory?
| DeployedLSP8IdentifiableDigitalAsset, | ||
| LSP7DigitalAssetDeploymentOptions, | ||
| LSP8IdentifiableDigitalAssetDeploymentOptions, | ||
| } from '@lukso/lsp-factory.js/build/main/src/lib/interfaces/digital-asset-deployment' |
There was a problem hiding this comment.
Is this the factory that we stopped using a long time ago, or is this a different package? Also, the import looks a bit strange 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add starter project for RPC provider and hook it into Home.vue for testing.