Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #73

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Update dependencies #73

wants to merge 15 commits into from

Conversation

GMartigny
Copy link

  • Update all outdated dependencies.
  • Name all tests.
  • Fix linting

I encounter an issue with the updated jsDOM dependencies. In order to read localStorage and sessionStorage, jsDOM must have a defined origin (url option). Or else, it throws an exception.

When called without arguments, browser-env puts everything under global (including localStorage and sessionStorage).

A few possibilities:

  • The lib should have a default url ("http://whatever.com")
  • The lib should try/catch (warn ?) these exceptions
  • The lib should let the user deal with exceptions when getting localStorage and sessionStorage
  • ...

What do you think is best ?

Guillaume Martigny and others added 15 commits February 4, 2019 10:45
Update window and expected properties.
80e3ebd
Since [email protected], all tests should have a title.
ccb35de
Update outdated dependencies.
00cb51f
Fix linting warnings.
6a8e0b8
@lukechilds
Update window to version 4.2.6 (lukechilds#75)
ffb7083 
* Require [email protected]

* Set global properties as getters

Some properties will throw an error when accessed in certain conditions. We don't want to throw these errors, by accessing them when we setup the environemnt. Instead we should create getters for all window properties so they can throw the appropriate errors when accessed by user code.

* Update expectedProperties.json for [email protected]
@lukechilds
3.2.6
78b2eb0
@lukechilds
Update window to version 4.2.6 (lukechilds#75)
fd6d0b9 
* Require [email protected]

* Set global properties as getters

Some properties will throw an error when accessed in certain conditions. We don't want to throw these errors, by accessing them when we setup the environemnt. Instead we should create getters for all window properties so they can throw the appropriate errors when accessed by user code.

* Update expectedProperties.json for [email protected]
@lukechilds
3.2.6
05cfb05
Since [email protected], all tests should have a title.
2968819
Update outdated dependencies.
332da1a
Fix linting warnings.
1f5c9cf
Merge remote-tracking branch 'origin/updateDependencies' into updateD…
c06243b 
…ependencies
Update outdated dependencies again.
f25f043
Revert moving import so we can set global before.
a926ee9
Fix indent.
a2c269e
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a2c269e on GMartigny:updateDependencies into 71aed2b on lukechilds:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a2c269e on GMartigny:updateDependencies into 71aed2b on lukechilds:master.

@GMartigny
Copy link
Author

Sorry, I kind of f***ed up the PR, but it's now up-to-date with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GMartigny @coveralls @lukechilds