Feature: Add showCertificateExpiry property to status_page module #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have tested the modification today and created two status pages using the modified module. It works as desired and sets the bool property for the status page. |
|
I know it’s bad style to comment for an update but since half a year has passed now - what prevents this PR from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using your collection to configure an uptime instance and defining monitors & status page I came across the issue, that I cannot set the "showCertificateExpiry" property for a status page.
A quick look into the API reference (here: https://uptime-kuma-api.readthedocs.io/en/latest/api.html#uptime_kuma_api.UptimeKumaApi.save_status_page) revealed that the API has indeed the capability to configure this.
In this PR I have created a quick implementation for this feature and also added it to the unit test. I have not tested it myself so far, I will add a comment to this PR.
Please have look - it would really help us to get this merged.