Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40798: Exclude sky sources from RB classification #190

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

rai-harshit
Copy link
Contributor

Create a new pipelineTask that selects sources from the diaSource catalog and writes a goodSeeingDiff_candidateDiaSrc (or similar name) catalog that can be used as an input to TransiNetTask.

Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see fairly substantial changes in this package, so I would like to re-review after you have addressed my current comments.

python/lsst/ap/association/filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
python/lsst/ap/association/filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
python/lsst/ap/association/filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
python/lsst/ap/association/filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
python/lsst/ap/association/filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
tests/test_filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
tests/test_filterDiaSourceCatalog.py Show resolved Hide resolved
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to add in my initial review a request to deprecate the config doRemoveSkySources in TransformDiaSourceCatalogTask, and remove the code that handles sky sources around line 226 of that file. Instead, you could add a check to see if any sources are flagged as sky sources, and either raise an error if any are found.

Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a few straightforward comments, mostly to make your code style match LSST standards.

python/lsst/ap/association/filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
python/lsst/ap/association/filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
python/lsst/ap/association/filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
python/lsst/ap/association/filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
tests/test_filterDiaSourceCatalog.py Show resolved Hide resolved
tests/test_filterDiaSourceCatalog.py Outdated Show resolved Hide resolved
tests/test_filterDiaSourceCatalog.py Show resolved Hide resolved
python/lsst/ap/association/__init__.py Outdated Show resolved Hide resolved
@rai-harshit rai-harshit merged commit 14551fb into main Feb 7, 2024
2 checks passed
@rai-harshit rai-harshit deleted the tickets/DM-40798 branch February 7, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants