DM-23761: Add support for Kafka (SQuaRE Events) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonathansick
commented
Mar 4, 2020
jonathansick
commented
- Create SSL context for Kafka brokers
- Create a Producer
Note that this needs to be revised once kafkit 0.2 is released.
It creates the SSL context needed to connect to an SSL-secured Strimzi-based Kafka cluster. Most logic is implemented in kafkit.ssl, this helper just adds conventions around configuration of certificate paths and storage of the SSLContext in the app.
This code, originally from sqrbot-jr, sets up an AIOKafkaProducer in a cleanup context. It integrates the kafka_ssl_context work.
jonathansick
force-pushed
the
tickets/DM-23761
branch
from
8a7a928
to
f84f178
Compare
This is for the case of letting app initialization run even if a producer hasn't been configured. In this scenario, the app would need to explicitly test that safkir/kafka_producer is not None whenever it is being tested.
jonathansick
force-pushed
the
tickets/DM-23761
branch
from
2ada8ef
to
12708e7
Compare
This is not required, and the concatenate_certificates function is no longer provided by kafkit.ssl.
This initializer sets up a Confluent Schema Registry RegistryApi client and a RecordNameSchemaManager that registers schemas and makes a serializer available to the app.
The rst-linter is specifically used to ensure that the README and CHANGELOG are using plain reStructuredText which is compatible with pypi's reStructuredText parser.
jonathansick
force-pushed
the
tickets/DM-23761
branch
from
0279f20
to
996f261
Compare
This ensures that apps are being built with the newer version of aiokafka that resolves the UnknownMemberId consumer bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.