encourage astropy.table #676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
reviewed
May 21, 2024
| @@ -13,7 +13,7 @@ Integration of Astropy core into the LSST software stack is an ongoing process t | |||
| This document is not discussing Astropy affiliated packages, use of which must go through the standard :doc:`RFC </communications/rfc>` process. | |||
| Not all Astropy core packages can be used by default. | |||
|
|
|||
| The following packages can be used internally in packages if they do not leak into public APIs: | |||
| The following packages can be used internally in packages: | |||
There was a problem hiding this comment.
I think time and units are now accepted enough that they could even be in public APIs, not just internal. But I'm not sure we want the rest in APIs.
| .. _fitsio: https://github.com/esheldon/fitsio | ||
|
|
||
| .. warning:: | ||
|
|
||
| ``lsst.afw.fits`` must not be used in any new Python code, as it is not considered memory safe. | ||
|
|
||
| If not interacting with C++ classes the use of ``astropy.table`` is encouraged. |
There was a problem hiding this comment.
Maybe add: "In particular, the Table class has beneficial properties over Pandas DataFrame." ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.