-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize clang-format file #342
base: master
Are you sure you want to change the base?
Conversation
I like that the clangformat file only has the essentials for now, I think it makes it easier for discussion purposes. In the final version, however, we should change it back into a full file. I made the One (potentially) controversial change I've made is
The CI seems to be using clangformat 14. I would vastly prefer 18, because that's what MaMiCo uses, but we can discuss that further. We could also use git hooks to format all new files according to the clangformat, however AFAIK git hooks are not server side. |
|
Description
As discussed in issue #276 , we want to add a clang-format file to enforce an unified style in ls1.
For this, we have to:
.clang-format
fileCMake
to just run commandmake clang-format
for formatting (this is not working for now, help wanted!)make clang-format
for formattingIf we want to be very fancy, we could do something like in MegaMol.
Resolved Issues
I would recommend that this PR does not apply the formatting to the whole code base in ls1. This should be done in a separate PR for the sake of clarity.