Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of readers #332

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Cleanup of readers #332

wants to merge 2 commits into from

Conversation

HomesGH
Copy link
Contributor

@HomesGH HomesGH commented Jul 26, 2024 •
edited
Loading

ASCII reader

The method readPhaseSpaceHeader of the ASCII reader is not used in the code anymore. Instead, the data of the config xml was already employed to set according values.

It seems that the method readPhaseSpaceHeader of the ASCII reader is just used for tests, see here.

MPI_IOCheckpointWriter and MPI_IOReader

@cniethammer @FG-TUM
Do you know if the MPI_IOCheckpointWriter and MPI_IOReader classes are in use or working at all?

I couldn't find any reference and usage of those in the present code base.

On the history of the MPI_IOCheckpointWriter :

  • The class was introduced with this commit 4d3fa08 but didn' work correctly
  • According to this commit, it was fixed.

HomesGH added 2 commits July 26, 2024 09:48
@HomesGH
Deprecate readPhaseSpaceHeader of ASCII reader
c7f4729 
This method was not used in the code anymore. The config xml was already used to set according values.
@HomesGH
Add meaning full error message when using ASCII readPhaseSpaceHeader
b47d637
@HomesGH HomesGH added question Further information is requested clean-up related to the clean-up of the code and tech dept labels Jul 26, 2024
@HomesGH HomesGH marked this pull request as draft July 26, 2024 08:20
@FG-TUM
Copy link
Member

FG-TUM commented Jul 26, 2024 •
edited
Loading

After grepping the whole project, it seems MPI_IOCheckpointWriter is not used at all, and MPI_IOReader is only referenced from commented-out code once in PressureGradient, so it is also unused. Both are not registered as plugins, hence, they will probably not work at the moment.

I'd be in favor of removing them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clean-up related to the clean-up of the code and tech dept question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HomesGH @FG-TUM