Fixes to mamico plugin after mamico refactor #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflecting boundaries
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cniethammer
previously approved these changes
Nov 26, 2024
There was a problem hiding this comment.
I did not have time to test this - so just general remarks on the code.
Overall such huge PRs that include also out of topic modifications should be avoided and if not clearly state what was done in the PR description! Here I find new cmake and xml options beside general fixes and renamings of interfaces in the code ...
Co-authored-by: Christoph Niethammer <[email protected]>
…n/ls1-mardyn into mamico-postrefactor-fix
cniethammer
previously approved these changes
Nov 26, 2024
FG-TUM
requested changes
Nov 28, 2024
remove inlines Co-authored-by: FG-TUM <[email protected]>
Co-authored-by: FG-TUM <[email protected]>
Co-authored-by: FG-TUM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the mamico coding week, some files and functions were renamed. The plugin is now fixed to use these new names.
Fixes Issue #290