Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Counter to speed-up return of number of particles within container #217

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] Counter to speed-up return of number of particles within container #217

wants to merge 1 commit into from

Conversation

HomesGH
Copy link
Contributor

@HomesGH HomesGH commented Jan 19, 2022

Description

WIP

Related Pull Requests

WIP

Resolved Issues

WIP

How Has This Been Tested?

  • Test A

@HomesGH HomesGH added the WIP Work In Progress label Jan 19, 2022
@cniethammer cniethammer added the performance Performance enhancements label Nov 11, 2022
@cniethammer
Copy link
Contributor

The component class has a getNumMolecules() method to obtain the global number of molecules.
On the other hand the particle container interface provides getNumberOfParticles() that is used to obtain the local number of particles stored at an MPI process - which is expensive. We might want to cache this.

We should do a performance audit for relevant use cases to see the impact.

@cniethammer cniethammer self-assigned this Nov 11, 2022
@FG-TUM FG-TUM added the ProofOfConcept This PR will not necessarily be merged and just shows how a certain feature could be implemented. label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cniethammer cniethammer

Labels
performance Performance enhancements ProofOfConcept This PR will not necessarily be merged and just shows how a certain feature could be implemented. WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HomesGH @cniethammer @FG-TUM