-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lectures
: Hide slide pages until a date
#9868
Open
eceeeren
wants to merge
28
commits into
feature/lectures/hide-pdf-pages
Choose a base branch
from
feature/lectures/hide-pdf-pages-with-date
base: feature/lectures/hide-pdf-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lectures
: Hide slide pages until a date
#9868
eceeeren
wants to merge
28
commits into
feature/lectures/hide-pdf-pages
from
feature/lectures/hide-pdf-pages-with-date
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
client
Pull requests that update TypeScript code. (Added Automatically!)
label
Nov 26, 2024
eceeeren
force-pushed
the
feature/lectures/hide-pdf-pages
branch
from
November 26, 2024 09:37
d3b1d1d
to
0d228ea
Compare
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
eceeeren
force-pushed
the
feature/lectures/hide-pdf-pages
branch
from
December 18, 2024 13:22
039e239
to
71f7466
Compare
…f-pages-with-date
github-actions
bot
added
server
Pull requests that update Java code. (Added Automatically!)
database
Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment.
lecture
Pull requests that affect the corresponding module
labels
Dec 29, 2024
github-actions
bot
removed
server
Pull requests that update Java code. (Added Automatically!)
database
Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment.
lecture
Pull requests that affect the corresponding module
labels
Dec 29, 2024
…with-date' into feature/lectures/hide-pdf-pages-with-date
github-actions
bot
added
server
Pull requests that update Java code. (Added Automatically!)
core
Pull requests that affect the corresponding module
labels
Dec 29, 2024
github-actions
bot
added
the
lecture
Pull requests that affect the corresponding module
label
Jan 1, 2025
…hide-pdf-pages-with-date
…with-date' into feature/lectures/hide-pdf-pages-with-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
The feature to hide slide pages (#9667) has been implemented, allowing instructors to hide pages indefinitely. However, a new feature is needed to enable instructors to hide specific pages with more flexibility to enhance functionality. This feature should provide the following options:
1. Hide Indefinitely: Maintain the current functionality to hide pages permanently until manually unhidden.
2. Hide Until a Specific Date: Allow instructors to set a manual date and time for the pages to be automatically unhidden.
3. Hide Until an Exercise's Due Date: Link the hidden pages to an exercise's due date, ensuring they are unhidden when it is due.
Additionally, a scheduled job should be implemented to automatically unhide pages once the specified conditions are met. This enhancement will improve usability and provide greater control for instructors.
Description
To enable the functionality of hiding pages until a specific date, the following changes have been implemented:
1. PDF Preview Date Box Component: A new component named PDF Preview Date Box has been created.
Date Box Accessibility: The Date Box becomes accessible by clicking the "Hide" button when hovering over a page.
2. Hide Options: The Date Box allows instructors to configure hiding options for the selected page. It provides three choices:
3. Configuration View: Once the hiding configuration is saved, the current settings can be viewed by clicking the "View" button.
4. Show Page Popover: In the "Show Page" popover, the selected hiding date is displayed, along with an option to unhide the page.
5. Database Integration: The selected configurations are stored in the Slide table for persistence.
6. Scheduled Job: A scheduled job runs every minute, checking the Slide repository to automatically unhide slides that have reached their specified date.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots
1. Date Box component with different options selected
2. Show Page popover with different options selected