Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to libvips v8.16.0-rc2 #255

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

kleisauke
Copy link
Collaborator

No description provided.

@kleisauke
Copy link
Collaborator Author

We could perhaps backport https://github.com/strukturag/libheif/pull/1330.patch as a follow-up.

@lovell
Copy link
Owner

lovell commented Oct 22, 2024

I think there's a new version of libheif imminent - see strukturag/libheif@f396bd7

Not sure why the s390x build is failing, best guess would be some kind of regression in serde (as a librsvg dependency).

The most recent passing build - https://github.com/lovell/sharp-libvips/actions/runs/11437971230

2024-10-21T10:24:42.8161684Z    Compiling serde v1.0.204

This build:

2024-10-22T07:23:36.5375908Z #6 66.61    Compiling serde v1.0.211

@kleisauke
Copy link
Collaborator Author

Commit df811a1 should resolve the failing build, which was impacting more than just s390x. It does indeed seem a regression in serde.

@lovell lovell merged commit 2e7ace7 into lovell:main Oct 22, 2024
14 checks passed
@lovell
Copy link
Owner

lovell commented Oct 22, 2024

Dankjewel!

@kleisauke kleisauke deleted the vips-8.16.0-rc2 branch October 22, 2024 09:13
@kleisauke
Copy link
Collaborator Author

For reference, upstream serde issue: serde-rs/serde#2844.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants