Feat: Editor history visualization #24
Open
+2,171
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxch3n
changed the title
_Update_.Editor.history.visualization.mp4 |
|
Awesome! |
zxch3n
requested changes
Dec 24, 2024
| timestamp: number; | ||
| } | ||
|
|
||
| const storedOperations: StoredOperation[] = []; |
There was a problem hiding this comment.
This should be inside convertSyncStepsToNodes
| }); | ||
|
|
||
| // If the operation has not already been stored | ||
| if (!storedOperations.some(op => op.id === opId)) { |
There was a problem hiding this comment.
This is slow, you can use a Set to detect whether it's stored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced the editor history visualization system to improve operation history tracking and display in collaborative editing scenarios. The main improvements focus on:
editor-history.ts:BasicWithHistory: Added single editor history trackingSyncWithHistory: Improved two-editor synchronization with historyOfflineSyncWithHistory: Enhanced offline/online state handlingMultiOfflineSyncWithHistory: Added support for multiple editor synchronization