Feat: Implemented splash screen #84
Conversation
previewsplashscreen-fed-preview.mp4 |
| android:height="118dp" | ||
| android:width="118dp" |
There was a problem hiding this comment.
It's better to set it to 100dp x 100dp. I found that on Pixel 3a API 33 the current sizes (118dp) cause a crop.
The guidelines suggests to use a vector icon, but a this time I don't have it.
There was a problem hiding this comment.
sorry for late response,
I got them, I'm forgot to test the responsive for any screen, thanks for suggestion
| _isSplashScreenLoading.value = true | ||
| expirationDates = repository.getAll() | ||
| delay(2000) | ||
| _isSplashScreenLoading.value = false |
There was a problem hiding this comment.
Good. This codes added an additional delay to the call repository.getAll(), so I think it's better to use the delay to execute the call to the database. I propose this code:
_isSplashScreenLoading.value = true
val deferred = async {
expirationDates = repository.getAll()
}
delay(1000)
deferred.await()
_isSplashScreenLoading.value = falseHere the call to the database is executed asynchronously, and the delay don't wait the db call to terminate. However, if the call to the db is longer that the delay, the await() tells the app to don't visualize the list of item unit the db call returned.
Also I think 1 second delay is enough.
Do you agree?
There was a problem hiding this comment.
awesome, I have updated the code as your great advice. strongly agreed.
tested device for splash screen area (asset not overlapped) :
redmi 9 A12 ✅ | emulator Pixel 5 A11 ✅ | other devices ❎
|
Great work! Thank you! |
this PR is under the tagline
simple things are the best most of times~ quotes by @lorenzovngl