Added UI Settings for top bar font weight #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzovngl
requested changes
Sep 21, 2023
There was a problem hiding this comment.
I built and ran the app with these changes and... thinking about it... a separate activity for UI settings is not the best idea considering the limited number of settings.
I think the best choice is to put all in the SettingsActivity, separating behavioral settings from appearance settings using two headers:
Behavior
[Date format]
[Notification time]
Appearance
[Theme]
[Dynamic colors]
[Top app bar font weight]
lorenzovngl
requested changes
Sep 28, 2023
|
I don't know why this bug is coming. I just interchanged the if conditions the bug went away. |
lorenzovngl
approved these changes
Sep 28, 2023
lorenzovngl
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.