Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extension sdk 3.1 removal - wip #1400

Closed
wants to merge 1 commit into from

Conversation

bryans99
Copy link
Collaborator

👋👋 Thank you for contributing to Looker sdk-codegen (⚡️🍣)

  • 👆 Make sure your pull request title follows Pull Request Title Guidelines from our Contribution guide
  • 👉 Don't forget to replace these instructions with your ✨awesome✨ description of what this change actually does. Additionally, it's great to include context on how it works and why the change was needed.
  • 👇 Edit "Developer Checklist" to reflect items relevant to this PR (and try to make sure to check everything off before asking for review)

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Copy link
Contributor

Typescript Tests

0 files   -     6  0 suites   - 60   0s ⏱️ - 11m 48s
0 tests  - 229  0 ✔️  - 225  0 💤  -   4  0 ❌ ±0 
0 runs   - 552  0 ✔️  - 536  0 💤  - 16  0 ❌ ±0 

Results for commit d4b1fcc. ± Comparison against base commit 3ea3cfc.

This pull request removes 229 tests.
AccessToken defaults with empty token ‑ AccessToken defaults with empty token
AccessToken has a 10 second lag time for expiration ‑ AccessToken has a 10 second lag time for expiration
AccessToken is active with full token ‑ AccessToken is active with full token
ApiMethods full path with auth is just full path ‑ ApiMethods full path with auth is just full path
ApiMethods full path without auth is just full path ‑ ApiMethods full path without auth is just full path
ApiMethods path not prefixed if base url not set ‑ ApiMethods path not prefixed if base url not set
ApiMethods relative path with auth is api path ‑ ApiMethods relative path with auth is api path
ApiMethods relative path without auth is just base ‑ ApiMethods relative path without auth is just base
Browser session authenticate causes authentication ‑ Browser session authenticate causes authentication
Browser session getToken is mocked ‑ Browser session getToken is mocked
…

Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit d4b1fcc.

@jkaster
Copy link
Contributor

jkaster commented Sep 11, 2024

obsolete

@jkaster jkaster closed this Sep 11, 2024
@jkaster jkaster deleted the bnr/extension-sdk-31-removal branch September 11, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants