feat: Embed SDK 2.0 Development (wip) #210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryans99
requested review from
ryandunlavy,
jkaster,
josephaxisa,
pjmsmithgoogle,
treshugart and
prescottbreeden
|
The beginnings of Embed SDK 2.0. Very much a WIP but I want to get a backup |
jkaster
reviewed
Dec 27, 2024
2. Upgrade karma type script packages. 3. Update documentation. 4. Reduce exposed embed sdk 2.0.0 classes to the minumum. 5. Update version to 2.0.0 6. Fix minor issue with comment in demo. 7. Correct copyright dates.
out code. 2. Fix internal event handler setup so that users of the sdk can listen to events (internal event handler was overwriting handlers added with "on". 3. Fix cookieless login. Incorrect separator used. 4. Fix asLookConnection return type. Was ILookerEmbedExtension. Now is ILookerEmbedLook (copy pasta error). 5. Fix LookerEmbedSDKFactory constructor input type. Now is interface. 6. Initial karma tests for 2.0.
2. Various fixes for issues found while writing tests for LokerEmbedExSDK
2. Add more withApiHost and withAuth tests to LookerEmbedExSDK tests 3. Hide internal properties and methods from documentation 4. Regenerate documentation
2. LookerEmbedExSDK test update 3. doc cleanup 4. Clean up function names 5. Remove unnecessary assertions 6. Clean up generateTokens error handling 7. Fix appendRequiredParameters processing for sandboxed host 8. Add clarifying comments for sandboxed host 9. Fix connect for private embed 10. Fix isCookielessEmbed check (replaces assertions)
2. Update docs to reflect generatTokens change
does not support it) 2. fix generateTokens handling of fetch init object 3. clean up generate error handling 4. correct initCookieless generateTokens typing 5. more EmbedClientEx tests
2. Updated documentation to reflect removed method 3. EmbedConnection.loadUrl method is the only method for setting default values for pushHistory and waitUntilLoaded 4. DashbordConnection tests 5. Updated EmbedClientEx tests to spy on mocks instead of connection. Spy ons now callThrough. 6. EmbedConnection tests 7. Add mock sendAndReceive method
2. ExploreConnection test 3. ExtensionConnection test 4. LookConnection test
SDK. 2. Rename original demo to multi frame demo 3. Rename new demo to single frame demo 4. Change title of message example tp Embed Message API Demo
2. Fix bug in sanitizeHostUrl function which broke everything 3. sanitizeHostUrl now throws an error if URL is invalid 4. Add sanitizeEmbedUrl which adds missing parameters if necessary, strips protocl, hostname, port if necessary, prefixes with /embed if necessary. Throws an error if URL is invalid
2. URL only signed for first IFRAME
2. Update README
2. Move private functions to bottom of class 3. Document IEmbedConection
2. Add withAllowLoginScreen to builder
of useCookieless
easier. 2. Remove access to url from builder (prevents private embed issues) 3. Fix private embed issue. No longer relies on builder.url presence and uses builder.embedUrl instead. 4. Rename loadDashboard method to loadDashboard2 in order to support legacy loadDashboard method.
tokens amongst all IFRAMES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.