Bottom overflow issue, when both English and Nepali dates are in view, in the calendar header fixed #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rojanshr1996
commented
May 16, 2023
•
rojanshr1996
commented
- Bottom overflow issue, when both English and Nepali dates are in view, was fixed by commenting out the static height (_kDayPickerRowHeight) given to the header row widget.
- Custom subtitle text style added for the English subtitle date in the calendar header (month/month-year).
added 2 commits
May 16, 2023 12:27
…RowHeight commented out to remove the bottom overflow erorr in the calendar header
rojanshr1996
changed the title
rojanshr1996
changed the title
|
@rojanshr1996 Great work on the PR, please can you do the following things
Thank you |
lohanidamodar
requested changes
Jun 2, 2023
| @@ -21,6 +21,9 @@ class HeaderStyle { | |||
| /// Style for title Text (month-year) displayed in header. | |||
| final TextStyle titleTextStyle; | |||
|
|
|||
| /// Style for subtitle Text (month/month - year) displayed in header. | |||
| final TextStyle subTitleTextStyle; | |||
There was a problem hiding this comment.
subTitle should be subtitle instead
| @@ -1,8 +1,7 @@ | |||
| part of clean_nepali_calendar; | |||
|
|
|||
| typedef HeaderDayBuilder = Widget Function(String headerName, int dayNumber); | |||
|
|
|||
| const double _kDayPickerRowHeight = 40.0; | |||
| const double _kDayPickerRowHeight = 52.0; | |||
There was a problem hiding this comment.
May be we should different value for when both dates are visible and when only nepali date is visible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.