Improve rendering of highlights on rotated PDF pages #11174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes extend the conversion methods viewportToScaled and scaledToViewport to respect any rotation of the text layer used by PDF.js for rendering the individual pages, which may have a different rotation per page. The calling functions are changed accordingly, depending on whether the act on elements contained in the rotated textLayer or on temporary highlights outside that container.
This makes highlights useful for PDFs containing rotated pages, which previously suffer from the bug reported in #11099.
There is still a problem with moving and resizing highlights on rotated pages. This doesn't work in the current release and is not fixed by this pull request. It is not a regression, just an unsolved problem. Still, I prefer to keep my first pull request to Logseq small and clear.