-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Use diffrent ports for tests #1093
Open
NexVeridian
wants to merge
3
commits into
loco-rs:master
Choose a base branch
from
NexVeridian:use-diffrent-ports-for-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: Use diffrent ports for tests #1093
NexVeridian
wants to merge
3
commits into
loco-rs:master
from
NexVeridian:use-diffrent-ports-for-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NexVeridian
force-pushed
the
use-diffrent-ports-for-tests
branch
from
December 19, 2024 01:05
2a0247b
to
3701aab
Compare
NexVeridian
changed the title
test: Use diffrent ports for tests, drop serial_test
test: Use diffrent ports for tests
Dec 19, 2024
NexVeridian
force-pushed
the
use-diffrent-ports-for-tests
branch
from
December 19, 2024 01:25
3701aab
to
db412d2
Compare
@NexVeridian do you see improvement in the CI test timings? |
Yes, CI has less threads though, so it's not as noticeable It should only be in Before
After
After, Locally
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr changes the tests in
tests/controller/middlewares.rs
to use a different port for each testAllowing all the tests run from the root of the repo to run in parallel
This might effect the tests in
examples/demo
ande2e
but I think it doesn't?Running
cargo nextest run
, at the root of the repo, without--test-threads 1
is also fixed by this prBenchmarks
Before
After
nextest
logs