-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#678] fixes NPE using SearchView #680
Open
fgdrf
wants to merge
6
commits into
locationtech:master
Choose a base branch
from
fgdrf:F_FIX_ISSUE_678
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8ee2cbc36a1cca3c559b75fb6c2858acb8059d3d Signed-off-by: Frank Gasdorf <[email protected]>
Change-Id: I6c9281cbc82ff319a4e7f5d5d01dd252716ad5b3 Signed-off-by: Frank Gasdorf <[email protected]>
Change-Id: I1d7e4a3df7d6186875f29af21fbb23c4f17d01e3 Signed-off-by: Frank Gasdorf <[email protected]>
Change-Id: If13cfb5c1bc3cc5bb9b4a4038d4df1a970f6d93e Signed-off-by: Frank Gasdorf <[email protected]>
fgdrf
force-pushed
the
F_FIX_ISSUE_678
branch
from
February 7, 2022 07:37
7518664
to
27e7579
Compare
In the description you may refer to the issue to link them :) |
resources, if the namespace of the type is null Change-Id: I255a9f14a3999e7286570dcf50ed0014b524d458 Signed-off-by: Frank Gasdorf <[email protected]>
fgdrf
force-pushed
the
F_FIX_ISSUE_678
branch
from
February 7, 2022 14:18
27e7579
to
c666048
Compare
fgdrf
changed the title
fixes NPE reported in issue 678
[#678] fixes NPE using SearchView
Feb 7, 2022
fgdrf
commented
Feb 8, 2022
@@ -199,7 +199,7 @@ protected DB2GeoResourceInfo createInfo(IProgressMonitor monitor) throws IOExcep | |||
|
|||
icon = Glyph.icon(ft); | |||
keywords = new String[] { "db2", //$NON-NLS-1$ | |||
ft.getName().getLocalPart(), ft.getName().getNamespaceURI() }; | |||
ft.getName().getLocalPart(), ft.getName().getURI() }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be similar to shp implementation. check for namespace, if not null, add it otherwise skip it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.