-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Builds and Tests all major versions of Java on Ubuntu and MacOS. #638
base: master
Are you sure you want to change the base?
CI Builds and Tests all major versions of Java on Ubuntu and MacOS. #638
Conversation
Not sure about the last check related to the Eclipse Foundation's Contributor Agreement. I signed up and submitted the info. |
.github/workflows/build-and-test.yml
Outdated
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
java: [8, 8.0.192, 11, 11.0.9, 12, 13, 13.0.4, 14.0.2, 15] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just leave it to the major versions and not the patch releases, also why test versions that are already EOL (OpenJDK 12 /13 / 14 have all passed)...
I'd just stick to LTS versions (8 and 11)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Michael,
Sounds good to avoid patch release, however I’d keep all major versions. I and others use Java/JavaFX 14 & 15!
Btw, I did test 16ea and it failed for some reason so I took it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you agree with me. Did you want me to make the change or will you make the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had made the change to remove EOL and patched versions.
@carldea what email address did you use for the Eclipse Contributor Agreement? |
It is carl.dea at gmail.com as opposed to carldea at gmail.com, in GitHub it's run together. Thank you! |
@carldea ah, ok, did you sign-off your commits with Each commit needs to be signed off; I know it is a pain. It may be easier to merge squash and open a new PR. |
@dr-jts I am liking the idea of checking out the JTS build on multiple versions of Java. I doubt we'll see anything come up. The checks appear to run relatively quickly. Any feedback on this PR? |
No, but will do.
Sounds great. Will create another PR. |
The contribution type: enhancement
The module being contributed to: jts-build
CI Builds and Tests all major versions of Java (8-15) on Ubuntu and MacOS.
The following matrix describes the Java versions and OS platforms.