Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add track ID #38

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add track ID #38

merged 1 commit into from
Jan 6, 2025

Conversation

Richard-Degenne
Copy link
Contributor

When fetching tracks from a release, each track is given its own MBID.

This pull request adds a new property id on the Track model, and updates the track binding to parse the id attribute from API responses.

release = MusicBrainz::Release.find('3c19711b-b9df-495b-a610-634b1fc48763')
release.tracks.first.id

# => "456f7e7e-87f0-48d5-86b9-f0597d1a1072"

localhots
localhots approved these changes Jan 6, 2025
View reviewed changes
Copy link
Owner

@localhots localhots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@localhots localhots merged commit 45ca1f7 into localhots:master Jan 6, 2025
1 check passed
@Richard-Degenne Richard-Degenne deleted the feat/track-id branch January 7, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localhots localhots localhots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Richard-Degenne @localhots