Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Bind the selected group name in the rename modal. #5159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ramu-narasinga
Copy link

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

Bind the selected group name in the rename group modal. The issue was that when there is multiple groups with sessions and you choose to rename a group, previously selected group name appears. Attached video.

📝 补充信息 | Additional Information

  1. Added useEffect dependent on group and then updated the setInput so that group.name fetched from the store is set in input.
 useEffect(() => {
    setInput(group?.name);
  }, [group]);
Before fix:
before-fix.mov
After fix:
after-fix.mov

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 23, 2024
Copy link

vercel bot commented Dec 23, 2024

@ramu-narasinga is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @ramu-narasinga

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@dosubot dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷 size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants