🐛 fix: user feedback for empty/long group names in create/edit group modals #5077
+2
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
To show an alert when the user submits an empty or long group name in Create Group and Rename Group Modals.
📝 补充信息 | Additional Information
if
block in CreateModalTo allow the input length check that shows an alert if the title does not meet the criteria.
if
block in RenameGroupModalTo allow the input length check that shows an alert if the title does not meet the criteria.
2.1 And this forced to ensure types are valid for
input
state variable, as a resultinput
state is initialized to '' (empty string - following the same convention in CreateGroupModal)2.2 Added fallback to empty string in the
onCancel
, in case the group.name is empty.