Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more video links to archive, plus small fixes to speakers #134

Merged
merged 2 commits into from
Feb 16, 2017

Conversation

katebee
Copy link

@katebee katebee commented Feb 14, 2017

Affects: http://localhost:3000/archive.html

Adding more youtube links for #96 🙌 😄

Additional changes:

  • IIRC, Peter Elger had to drop out in March 2016 and Simon Ordish stepped in? This changes the speaker list for that month accordingly, and added the link to the video of Simon's talk.

  • Removes a space before one of the talk titles

  • Commit the generated files

  • bump the service worker version number

  • Remove numbering from talk titles of November 2016, and switch the order to match the youtube playlist

Notes

  • Is api/archive.json still in use anywhere? Can this file be deleted? I can't see any usages, and it appears to duplicate data in data/archive.json. Therefore I have not applied any changes to api/archive.json.

I have not committed any of the generated changes let me know if you would like them added
client/service-worker.js
docs/api/speclate/archive.json
docs/archive.html
docs/manifest.appcache
docs/service-worker.js

^^ UPDATE: have now committed the generated changes and the SW bump

@clarkie
Copy link
Member

clarkie commented Feb 14, 2017

+1 looks good but no idea with regards to your questions

@admataz
Copy link
Member

admataz commented Feb 14, 2017

Thanks @katebee - I'm also not 100% sure the answers to your questions - but looking through the source it makes sense to delete api/archive.json - @simonmcmanus should be able to confirm - but meanwhile I think we can go ahead with this PR

As for the other changes - they look good - the numbering on the talk was a quick method to sort the talks for the home page when they were there - thanks for sorting that.

I think the generated files should be included in the commit as these are needed for the deployment. If you can commit them too, I'll merge.

@katebee
Copy link
Author

katebee commented Feb 16, 2017

@admataz thanks, I've added the generated files.

I've bumped the service worker version number, assuming the generated files fall under cached static resources 😅

@simonmcmanus
Copy link

👍 thanks @katebee

I've not been able to test it but it looks good to me. :)

I think your right that we don't need api/archive.json anymore. Feel free to delete it.

@simonmcmanus simonmcmanus merged commit 5be9315 into master Feb 16, 2017
@simonmcmanus simonmcmanus deleted the kw-update-archive branch February 16, 2017 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants