Ability to resize images in Fototoon #1564
Open
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llaske
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, the image was displayed via "backgroundImage", so its only way to resize it was to resize '#mainCanvas' div ~ entire page, that will be no good.
I tried to use existing Globe 'TYPE_Rectangle' by adding bitmap (easel js) to it, but many other component are "TYPE_RECTANGLE" and it is hassle to make each component behave same after these changes (This is my final result but bitmap fills image in parent element).
Final solution that i can understand is creating a unique Globe type "TYPE_IMAGE" and working with it, that may takes time. If someone is willing to help me with this then i will continue. #1551