-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: response cookie extraction #3045
base: v3.0
Are you sure you want to change the base?
fix!: response cookie extraction #3045
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.0 #3045 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 322 322
Lines 14733 14736 +3
Branches 2343 2344 +1
=======================================
+ Hits 14477 14480 +3
Misses 117 117
Partials 139 139 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this looks good from my pov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable fix but a breaking change, so we’ll have to stash this for version 3.
@floxay @provinzkraut can we merge this now |
a1e59c9
to
21de2dd
Compare
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3045 |
c517c0b
to
2536957
Compare
81081dd
to
a4d7ea1
Compare
4dc78a8
to
81a323f
Compare
d285738
to
7de5a82
Compare
* Trigger documentation build * Trigger documentation build * docs: update to v3 style * docs: move some things to litestar.dev repo, change versioning, add environment tag * docs: update landing page * chore: update lockfile * chore: add AA upper constraint * fix(docs): re-colonize * docs: enable sphinx-togglebutton * docs: use current year var * deps: update deps * fix(docs): do not link __name__ for now * fix(docs): use correct link to page --------- Co-authored-by: Peter Schutt <[email protected]>
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
…deprecated params of internal `ExceptionHandlerMiddleware` (litestar-org#3435) * refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (litestar-org#3393) * Remove 'app' parameter from `.to_asgi_response` * Remove debug param * Remove exception_handlers param * Remove litestar.middleware.exceptions
Port parse_values_from_connection_kwargs changes
v3 branch is available with changes so this could be merged into that |
8df1b17
to
33ded66
Compare
466de2a
to
2292b5d
Compare
dd4215a
to
126a504
Compare
c56cc1c
to
670a5cd
Compare
Fixes #3040