Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: response cookie extraction #3045

Open
wants to merge 22 commits into
base: v3.0
Choose a base branch
from

Conversation

floxay
Copy link
Contributor

@floxay floxay commented Jan 29, 2024

Fixes #3040

@floxay floxay requested review from a team as code owners January 29, 2024 01:32
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (43e3041) to head (21de2dd).
Report is 16 commits behind head on v3.0.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.0    #3045   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         322      322           
  Lines       14733    14736    +3     
  Branches     2343     2344    +1     
=======================================
+ Hits        14477    14480    +3     
  Misses        117      117           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks good from my pov

Copy link
Member

@provinzkraut provinzkraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable fix but a breaking change, so we’ll have to stash this for version 3.

@provinzkraut provinzkraut added 3.x This is related to Litestar version 3 Breaking 🔨 labels Feb 3, 2024
@provinzkraut provinzkraut added the Blocked 🚫 This is blocked by something label Feb 14, 2024
@peterschutt peterschutt changed the base branch from main to v3.0 March 26, 2024 01:49
@JacobCoffee
Copy link
Member

@floxay @provinzkraut can we merge this now

@provinzkraut provinzkraut force-pushed the response-cookie-extraction-change branch from a1e59c9 to 21de2dd Compare April 7, 2024 16:57
Copy link

github-actions bot commented Apr 7, 2024

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3045

@provinzkraut provinzkraut force-pushed the v3.0 branch 3 times, most recently from c517c0b to 2536957 Compare April 27, 2024 07:15
@provinzkraut provinzkraut force-pushed the v3.0 branch 2 times, most recently from 81081dd to a4d7ea1 Compare April 28, 2024 11:19
@provinzkraut provinzkraut force-pushed the v3.0 branch 2 times, most recently from 4dc78a8 to 81a323f Compare May 26, 2024 07:39
@provinzkraut provinzkraut force-pushed the v3.0 branch 3 times, most recently from d285738 to 7de5a82 Compare June 21, 2024 19:21
JacobCoffee and others added 2 commits July 21, 2024 14:01
* Trigger documentation build

* Trigger documentation build

* docs: update to v3 style

* docs: move some things to litestar.dev repo, change versioning, add environment tag

* docs: update landing page

* chore: update lockfile

* chore: add AA upper constraint

* fix(docs): re-colonize

* docs: enable sphinx-togglebutton

* docs: use current year var

* deps: update deps

* fix(docs): do not link __name__ for now

* fix(docs): use correct link to page

---------

Co-authored-by: Peter Schutt <[email protected]>
* Remove deprecated StaticFiles and StaticFilesConfig
* remove special casing of static files app from handlers/router
* remove outdated docs sections
* Add what's new section
* Rename tests for consistency
provinzkraut and others added 2 commits July 21, 2024 14:01
…deprecated params of internal `ExceptionHandlerMiddleware` (litestar-org#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (litestar-org#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
@JacobCoffee
Copy link
Member

v3 branch is available with changes so this could be merged into that

@JacobCoffee JacobCoffee removed the Blocked 🚫 This is blocked by something label Aug 12, 2024
@github-actions github-actions bot added Blocked 🚫 This is blocked by something size: small type/bug and removed 3.x This is related to Litestar version 3 labels Aug 12, 2024
@JacobCoffee JacobCoffee removed the Blocked 🚫 This is blocked by something label Aug 12, 2024
@provinzkraut provinzkraut force-pushed the v3.0 branch 3 times, most recently from 8df1b17 to 33ded66 Compare August 28, 2024 16:32
@provinzkraut provinzkraut force-pushed the v3.0 branch 4 times, most recently from 466de2a to 2292b5d Compare September 14, 2024 09:51
@provinzkraut provinzkraut force-pushed the v3.0 branch 3 times, most recently from dd4215a to 126a504 Compare September 21, 2024 11:13
@provinzkraut provinzkraut force-pushed the v3.0 branch 4 times, most recently from c56cc1c to 670a5cd Compare November 29, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ResponseDataExtractor merges per cookie attributes
5 participants