fix: DTOs for generic types #2512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is_subclass_of() Using `is_class_and_subclass()` is dangerous, because it hides things. Simply returning `False` if a type isn't a class isn't necessarily what we want. A good example of this is that one of the things that we needed to fix for this PR was to add `ClassVar` to our set of wrapper types. Just like `Required` et al., `ClassVar` isn't an alias for a builtin, it is a type that provides more information to type checkers. However, due to `is_class_and_subclass()` `FieldDefinition.is_subclass_of(int)` would return `True` for `Required[int]`, but `False` for `ClassVar[int]`. This is something that we would have caught earlier were it not for `is_class_and_subclass()`. The other change required to get this through was to return `False` from `FieldDefinition.is_subclass_of()` if the type is a `Literal`. This is not correct, but is the same as current behavior, and I want to take some time to think about how we should handle these.
peterschutt
force-pushed
the
dto-for-generic-types
branch
from
71548dd to
0b591b6
Compare
peterschutt
force-pushed
the
dto-for-generic-types
branch
from
0b591b6 to
af7ba5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Close Issue(s)
Closes #2500