Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pydantic v2 as dev dependency #2339

Closed
wants to merge 4 commits into from
Closed

Conversation

guacs
Copy link
Member

@guacs guacs commented Sep 23, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

  • update the version in pyproject.toml
  • add pydantic v2 as a dev dependency without which poetry will install pydantic v1 since piccolo has a <2.0 constraint

@guacs guacs requested review from a team as code owners September 23, 2023 08:57
@provinzkraut
Copy link
Member

It looks like this doesn't work because of the other constraints we have.

@guacs
Copy link
Member Author

guacs commented Sep 23, 2023

It looks like this doesn't work because of the other constraints we have.

Hm..maybe pydantic needs to be removed first before installing v1. Let me test the CI with those changes locally.

@cofin
Copy link
Member

cofin commented Sep 30, 2023

Maybe this gets rolled into the PDM swap?

@cofin
Copy link
Member

cofin commented Oct 7, 2023

@guacs I think we can close this now that we've moved to PDM. I'm pretty sure it will get installed by default now. Thoughts?

@guacs
Copy link
Member Author

guacs commented Oct 7, 2023

@guacs I think we can close this now that we've moved to PDM. I'm pretty sure it will get installed by default now. Thoughts?

Agreed.

@guacs guacs closed this Oct 7, 2023
@guacs guacs deleted the pydantic-versioning branch October 7, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants