Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shield-text CLI command #2740

Merged
merged 5 commits into from
May 20, 2024
Merged

shield-text CLI command #2740

merged 5 commits into from
May 20, 2024

Conversation

kziemianek
Copy link
Member

@kziemianek kziemianek commented May 17, 2024 •
edited

Adds CLI command shield-text for encrypting arbitrary string with worker's shielding key.

Assertion's secrets are stored in parachain storage in such form.

@kziemianek kziemianek requested a review from a team May 17, 2024 12:55
@linear Linear
Copy link

linear bot commented May 17, 2024

P-734 CLI command for encrypting assertion secrets

jonalvarezz
jonalvarezz approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@jonalvarezz jonalvarezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good to me.

nitpick: the naming. shield-string sounds more straightforward to me. Or simply sign-message, encrypt. naming is hard. so no strong opinion about it 😄

@kziemianek
Copy link
Member Author

looking good to me.

nitpick: the naming. shield-string sounds more straightforward to me. Or simply sign-message, encrypt. naming is hard. so no strong opinion about it 😄

Thanks @jonalvarezz , I've renamed the command to shield-text. Naming is important, especially for public interface.

@kziemianek kziemianek enabled auto-merge (squash) May 20, 2024 19:35
@kziemianek kziemianek merged commit 51c4cb7 into dev May 20, 2024
33 checks passed
@kziemianek kziemianek changed the title Shield string CLI command shield-text CLI command May 20, 2024
@kziemianek kziemianek deleted the p-734-cli-command-for-encrypting-assertion-secrets branch May 20, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonalvarezz jonalvarezz jonalvarezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kziemianek @jonalvarezz