Remove sidechain functionality from bc-worker #2660
Conversation
|
cc @kziemianek @felixfaisal could you please take a look at this PR? Thanks! |
|
returned back @kziemianek , @Kailai-Wang any tips what else might be addressed within this task? |
| }, | ||
| EnclaveMetric::TopPoolSizeSet(pool_size) => { | ||
| ENCLAVE_SIDECHAIN_TOP_POOL_SIZE.set(pool_size as i64); | ||
| }, | ||
| EnclaveMetric::TopPoolSizeIncrement => { | ||
| ENCLAVE_SIDECHAIN_TOP_POOL_SIZE.inc(); |
There was a problem hiding this comment.
Can this metric be removed together with related code ?
There was a problem hiding this comment.
it used at two functions process_top and remove_top, so it seems they used at code we utilise.
// Update metric
if let Err(e) = self.ocall_api.update_metric(EnclaveMetric::TopPoolSizeIncrement) {
warn!("Failed to update metric for top pool size: {:?}", e);
}do you think this metrics irrelevant anymore?
There was a problem hiding this comment.
top pool is a sidechain functionality. If we aim for getting rid of sidechain related code from bc-worker it should be removed too.
There was a problem hiding this comment.
great then I'll review author functionality and will try to remove as much as possible. Thanks
There was a problem hiding this comment.
Hey @kziemianek, I've managed to remove some functionality with one of latest commits but it seems whole Author's logic used across the bitacross project and not sure is it relevant or not. 🤔
Probably I'd finish with only this chunk of work and merge it. What do you think?
|
Want to get this PR done @Traf333 ? :) |
I have to remove a trusted operations functionality. Should be pretty quick, though I was focused on higher priority tasks |
Traf333
force-pushed
the
p-647-remove-sidechain-functionality-from-bc-worker
branch
from
8ac5463
to
a5dd978
Compare
Traf333
force-pushed
the
p-647-remove-sidechain-functionality-from-bc-worker
branch
from
a5dd978
to
63a881f
Compare
|
the changes are not relevant anymore
|
Context
this PR tends to remove redundant code for bc-worker since we don't use sidechain there. In addition it removes a
changelogfolder which uses ruby language and not used at our project