Fix rpath for libraries in subfolders of usr/lib and for executables in usr/lib/libexec #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rpath of libraries in subfolders of usr/lib should be $ORIGIN/<location of usr/lib relative to the dirname of the library> instead of just $ORIGIN, e.g. for usr/lib/sasl2/libscram.so.3.0.0 it should be $ORIGIN/..
gcc 12 requires explicitly including <array> when using std::array.
|
Additionally, I'm wondering why linuxdeploy sets the rpath to $ORIGIN for deployed dependencies and for existing executables, but appends the calculated rpath to the existing rpaths for libraries already existing in the AppDir. My guess would be that the rpaths of existing libraries is not overwritten to avoid breaking some dependencies. Is this correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make the rpaths of ELF files in subfolders of usr/lib more correct (if I understand rpath correctly).