Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lockscreen protocol for ShutdownApplet #900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add lockscreen protocol for ShutdownApplet #900

wants to merge 1 commit into from
+200 −3

Conversation

18202781743
Copy link
Contributor

as title.

@18202781743
Copy link
Contributor Author

@xionglinlin

xionglinlin
xionglinlin previously approved these changes Nov 23, 2024
View reviewed changes
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在treelandlockscreen.cpp文件中，workder函数拼写错误，应为worker。
  • treelandlockscreen.cpp文件中的shutdown函数和switchUser函数缺少对impl指针的空指针检查。
  • treelandlockscreen.cpp文件中的shutdown函数和switchUser函数可能需要异常处理机制，以防止在调用impl时发生错误。
  • treelandlockscreen.h文件中的TreeLandLockScreen类缺少对lock函数的注释说明。
  • treelandlockscreen.h文件中的TreeLandLockScreenWorker类缺少对lock函数的注释说明。
  • lockscreen-example/package/main.qml文件中的lockscreenApplet函数缺少对DS.applet返回值的空指针检查。
  • lockscreen-example/package/main.qml文件中的lockscreenApplet函数可能需要异常处理机制，以防止在调用DS.applet时发生错误。

是否建议立即修改:
是

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinshark yixinshark yixinshark approved these changes

@BLumia BLumia Awaiting requested review from BLumia

@tsic404 tsic404 Awaiting requested review from tsic404

@xionglinlin xionglinlin Awaiting requested review from xionglinlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@18202781743 @deepin-ci-robot @yixinshark @xionglinlin