Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: time date display tweak #1809

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

kegechen
Copy link
Contributor

  • remove timezone from longtime format (CST/GMT tttt)
  • use Outfit-light.ttf for time and date dispaly
  • remove unused ttf file
    image

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- remove timezone from longtime format (CST/GMT tttt)
- use Outfit-light.ttf for time and date dispaly
- remove unused ttf file
@kegechen
Copy link
Contributor Author

/merge

@deepin-bot
Copy link

deepin-bot bot commented Nov 25, 2024

This pr cannot be merged! (status: blocked)

@kegechen
Copy link
Contributor Author

/forcemerge

@kegechen kegechen closed this Nov 25, 2024
@kegechen kegechen reopened this Nov 25, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • datetimemodel.cpp中,移除了时间格式中的时区信息,但未提供替代方案或说明原因。
  • datetime.qrc中,移除了deepindigitaltimes-Regular.ttf文件,但未说明是否还有其他地方使用该字体。
  • TimeAndDate.qml中,使用了FontLoader来加载自定义字体,但未处理字体加载失败的情况。

是否建议立即修改:

@deepin-bot
Copy link

deepin-bot bot commented Nov 25, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 494be34 into linuxdeepin:master Nov 25, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants