Made maxOutput Prop #1015
Open
Made maxOutput Prop #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2022
linuswillner
requested changes
Oct 3, 2022
|
Sorry for spamming commits, I just kept remembering that I could make things a bit better. |
|
No problem, sorry for the delay - I don't really check in on this repo that often. I had one more suggestion but otherwise I think this is good. |
Don't worry about the delay, I know you're busy and that you provided this project in your free time! Thank you for all the work you've put into refining this feature. Appreciate the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while using react-console-emulator, that the terminal can get very laggy when many high-speed
terminal.pushToStdout()occur, and it gets much worse when the terminal output begins to be the length of millions. Implementing a solution using refs would be painful, and I think it would be much more reasonable to add the option for other people to use, as it is only one line of code.