Fix CI by using separate action to install PlatformIO environment #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use action from [micro_ros_platformio](https://github.com/micro-ROS/micro_ros_platformio/tree/main) to install PlatformIO in workflow runner. * Removes hacky and problematic workarounds from workflow (manually messing with `.platformio` and `penv`, python install).
|
@mergify backport humble galactic foxy |
✅ Backports have been created
|
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use action from micro_ros_platformio to install PlatformIO in workflow runner.
Removes hacky and problematic workarounds from workflow (manually messing with
.platformioandpenv, python install).Fixes #72 Rolling firmware failing to build in CI when installing micro_ros_platformio dependency.
I traced the issue back to micro-ROS/micro_ros_platformio#108 in that project.
I looked at the way micro_ros_platformio handles CI, and saw that they use a separate action to install PlatformIO on the CI runners. I copied this action into this repository and changed the workflow to use it. This fixed the CI build failure for Rolling, sped up the build time, and simplified the workflow structure.
I know the following command will fail, but @grassjelly not sure how else to signal backport intent.
@mergify backport humble galactic foxy