Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci for each ROS distro #40

Closed

Conversation

atticusrussell
Copy link
Contributor

@atticusrussell atticusrussell commented Jul 21, 2023

Implements issue proposed in #39 as a step on the path to fixing build errors across branches and targeting different ROS distros. Build failures indicate issues with a particular distro.

  • made PlatformIO firmware CI reusable and callable from other workflows

  • created individual workflows per ROS distro/branch to allow badges/statuses

  • firmware build status badges on README for each branch

* individual workflows per supported ROS distro

* made PlatformIO firmware CI reusable and callable from other workflows

* firmware build status badges on README for each branch
@atticusrussell
Copy link
Contributor Author

atticusrussell commented Jul 21, 2023

@grassjelly just wanted to note that the failure of the Galactic checks are a sign the CI works as intended, as the current "galactic" branch does not properly work with ROS Galactic

@atticusrussell
Copy link
Contributor Author

this PR has been closed until I solve why the nightly CI runs are failing

* swap from using pio install script to pip in firmware workflow

* manually create penv (platformio virtualenv)

* fix errors by swapping from python 3.9 to python 3.10

* Make README badge URLs relative and  repo agnostic
@atticusrussell
Copy link
Contributor Author

atticusrussell commented Aug 22, 2023

I solved the CI failures by swapping to using pip to install platformio on the runners and swapped from python 3.9 to 3.10.

@atticusrussell
Copy link
Contributor Author

atticusrussell commented Aug 22, 2023

@grassjelly this is now ready for merge. It fails CI, but for the correct reasons.
(the default linorobot2_hardware branch name should be changed from "galactic" to something like master or main) prior to merging this branch.

The reason the CI fails is the feature that will allow sustainable maintenance of this package for multiple ROS branches: once the default branch is renamed and the 'galactic' branch of this repo has its firmware/platformio.ini updated to use an older version of its dependency (such as in the galactic branch of my fork) its compilation will be properly tested for ROS galactic.

could probably be squash merged.

@atticusrussell
Copy link
Contributor Author

I plan to clean up this PR so that it only has 2 commits proposed and less chaotic messages

@atticusrussell atticusrussell deleted the feature/per-distro-ci branch August 29, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant