-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci for each ROS distro #40
ci for each ROS distro #40
Conversation
* individual workflows per supported ROS distro * made PlatformIO firmware CI reusable and callable from other workflows * firmware build status badges on README for each branch
@grassjelly just wanted to note that the failure of the Galactic checks are a sign the CI works as intended, as the current "galactic" branch does not properly work with ROS Galactic |
a4ce584
to
216722a
Compare
this PR has been closed until I solve why the nightly CI runs are failing |
* swap from using pio install script to pip in firmware workflow * manually create penv (platformio virtualenv) * fix errors by swapping from python 3.9 to python 3.10 * Make README badge URLs relative and repo agnostic
I solved the CI failures by swapping to using pip to install platformio on the runners and swapped from python 3.9 to 3.10. |
@grassjelly this is now ready for merge. It fails CI, but for the correct reasons. The reason the CI fails is the feature that will allow sustainable maintenance of this package for multiple ROS branches: once the default branch is renamed and the 'galactic' branch of this repo has its could probably be squash merged. |
I plan to clean up this PR so that it only has 2 commits proposed and less chaotic messages |
Implements issue proposed in #39 as a step on the path to fixing build errors across branches and targeting different ROS distros. Build failures indicate issues with a particular distro.
made PlatformIO firmware CI reusable and callable from other workflows
created individual workflows per ROS distro/branch to allow badges/statuses
firmware build status badges on README for each branch