-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C] Add wrapper for rust ffi doublets #302
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to approve
set(CONAN_DISABLE_CHECK_COMPILER TRUE) | ||
set(LINKS_PLATFORM_TESTS TRUE) | ||
set(LINKS_PLATFORM_BENCHMARKS TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were banned in the terminal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't joke
|
||
project(Platform.Data.Doublets) | ||
|
||
set(CONAN_DISABLE_CHECK_COMPILER TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o_o
c/CMakeLists.txt
Outdated
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add_library(${PROJECT_NAME}.Library INTERFACE) | ||
target_include_directories(${PROJECT_NAME}.Library INTERFACE src) | ||
|
||
target_link_directories(${PROJECT_NAME}.Library INTERFACE ${CMAKE_CURRENT_LIST_DIR}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not bad. Remove it style from your mind
# | ||
#if(${LINKS_PLATFORM_BENCHMARKS}) | ||
# add_executable(${PROJECT_NAME}.Benchmarks ${PROJECT_NAME}.Benchmarks/AllBenchmarks.cpp) | ||
# target_link_libraries(${PROJECT_NAME}.Benchmarks PRIVATE CONAN_PKG::gtest) | ||
# target_link_libraries(${PROJECT_NAME}.Benchmarks PRIVATE CONAN_PKG::benchmark) | ||
# target_link_libraries(${PROJECT_NAME}.Benchmarks PRIVATE ${PROJECT_NAME}.Library) | ||
#endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☹
memset(&createdLink, 0, sizeof(createdLink)); | ||
memset(&updatedLink, 0, sizeof(updatedLink)); | ||
memset(&foundLink, 0, sizeof(foundLink)); | ||
memset(&deletedLink, 0, sizeof(deletedLink)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not bad. Not bad...
UInt64Link createdLink; | ||
UInt64Link updatedLink; | ||
UInt64Link foundLink; | ||
UInt64Link deletedLink; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to main
, please
FfiLinks
CMakeLists
FfiTest
Platform.Data.Doublets.h