Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chart version, image tag and add docs #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix chart version, image tag and add docs #324

wants to merge 1 commit into from

Conversation

linki
Copy link
Owner

@linki linki commented Mar 24, 2021

Based on the feedback in #275 (comment) by @javajon.

Copy link

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@javajon
Copy link

javajon commented Aug 9, 2021

@mkilchhofer
Copy link

It's already live: https://www.katacoda.com/javajon/courses/kubernetes-chaos

But this scenario still uses the chart from the deprecated helm stable repo, right?

@mkilchhofer
Copy link

@linki is there anything open? Can we proceed? I'd love to help if needed :-).

@javajon
Copy link

javajon commented Aug 26, 2021

@mkilchhofer see updates for #275

@mkilchhofer
Copy link

mkilchhofer commented Aug 26, 2021

Hi @javajon Please see my comment over there (#275 (comment)) this is a perfect fine implementation. The value image.tag is only an override feature which is not enabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants