feat(app): Route frame count metrics #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
force-pushed
the
kate/record-body-data-part-deux
branch
from
378e494
to
843f57c
Compare
cratelyn
changed the title
cratelyn
force-pushed
the
kate/record-body-data-part-deux
branch
from
843f57c
to
82d97be
Compare
cratelyn
changed the base branch from
kate/record-body-data
to
kate/hoist-route-label-extractor
cratelyn
force-pushed
the
kate/record-body-data-part-deux
branch
from
cc0e8f0
to
67d56a0
Compare
cratelyn
force-pushed
the
kate/hoist-route-label-extractor
branch
from
2d8d0f2
to
a75492c
Compare
cratelyn
force-pushed
the
kate/record-body-data-part-deux
branch
2 times, most recently
from
3ae2592
to
082cb90
Compare
cratelyn
changed the title
This was referenced Nov 10, 2024
cratelyn
force-pushed
the
kate/record-body-data-part-deux
branch
from
082cb90
to
878881d
Compare
cratelyn
force-pushed
the
kate/hoist-route-label-extractor
branch
2 times, most recently
from
a84a157
to
71cca7f
Compare
cratelyn
force-pushed
the
kate/record-body-data-part-deux
branch
from
878881d
to
8868a39
Compare
cratelyn
force-pushed
the
kate/record-body-data-part-deux
branch
from
8868a39
to
389f7dc
Compare
### ⛅ overview this introduces a new tower middleware for Prometheus metrics, used for instrumenting HTTP and gRPC request bodies, and observing (a) the number of frames yielded by a body, (b) the number of bytes included in body frames, and (c) a distribution of the size of frames yielded. this builds upon the backend-level metrics added in #3308. this additionally uses the route label extractor, hoisted out of the retry middleware's Prometheus telemetry in #3337. ### 📝 changes * a `linkerd_http_prom::body_data::request::NewRecordBodyData::NewRecordBodyData` middleware is added, which complements the equivalent `linkerd_http_prom::body_data::response` middleware. * this is added to policy routes' metrics layer. see prometheus/client_rust#241 and prometheus/client_rust#242, which track upstream proposals to add accessors to `Histogram` that will allow us to make test assertions that metrics are working properly. for now, these are feature gated as also done in #3308. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/record-body-data-part-deux
branch
from
389f7dc
to
94f39e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(app): Route frame count metrics
⛅ overview
this introduces a new tower middleware for Prometheus metrics, used for
instrumenting HTTP and gRPC request bodies, and observing (a) the
number of frames yielded by a body, (b) the number of bytes included
in body frames, and (c) a distribution of the size of frames yielded.
this builds upon the backend-level metrics added in #3308. this
additionally uses the route label extractor, hoisted out of the retry
middleware's Prometheus telemetry in #3337.
📝 changes
a
linkerd_http_prom::body_data::request::NewRecordBodyData::NewRecordBodyDatamiddleware is added, which complements the equivalent
linkerd_http_prom::body_data::responsemiddleware.this is added to policy routes' metrics layer.
see prometheus/client_rust#241 and prometheus/client_rust#242, which
track upstream proposals to add accessors to
Histogramthat will allowus to make test assertions that metrics are working properly. for now,
these are feature gated as also done in #3308.
🔗 related