allow editing info for api managed teams (#410)

linkedin · Nov 22, 2023 · 0296952 · 0296952
1 parent a5df8c4
commit 0296952
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/src/oncall/__init__.py b/src/oncall/__init__.py
@@ -1 +1 @@
-__version__ = "2.0.4"
+__version__ = "2.0.5"
diff --git a/src/oncall/ui/static/css/oncall.css b/src/oncall/ui/static/css/oncall.css
@@ -958,6 +958,18 @@ div[data-admin="false"] .team-info .toggle-rotation {
  pointer-events: none;
 }
 
+div[info-admin="true"] [info-admin-action="true"] {
+ display: initial;
+}
+
+div[info-admin="false"] [info-admin-action="true"] {
+ display: none !important;
+}
+
+div[info-admin="false"] .team-info .toggle-rotation {
+ pointer-events: none;
+}
+
 /* Teams.schedules */
 
 .schedule-container[data-collapsed="true"] .module-schedule-wrapper {

diff --git a/src/oncall/ui/static/js/oncall.js b/src/oncall/ui/static/js/oncall.js
@@ -1358,20 +1358,26 @@ var oncall = {
  },
  checkIfAdmin: function(){
  var data = this.data.teamData;
+ var isInfoAdmin = false;
 
  data.isAdmin = false;
  if (oncall.data.userIsGod === 1) {
  data.isAdmin = true;
+ isInfoAdmin = true;
  } else {
  for (var i in data.admins) {
  // if team api managed and user is not superadmin then disable editing of team info
  if (data.admins[i].name === oncall.data.user && !data.api_managed_roster) {
  data.isAdmin = true;
+ isInfoAdmin = true;
+ } else if (data.admins[i].name === oncall.data.user) {
+ isInfoAdmin = true;
  }
  }
  }
 
  this.data.$page.attr('data-admin', data.isAdmin);
+ this.data.$page.attr('info-admin', isInfoAdmin);
  },
  toggleAddItem: function(){
  var $wrapper = $(this).parents('.add-item-wrapper'),

diff --git a/src/oncall/ui/templates/index.html b/src/oncall/ui/templates/index.html
@@ -303,7 +303,7 @@ <h4><strong><a class="landing-teams-name" target="_blank" href="mailto:{{data.cu
  <h3>
  {{name}}
  <span class="edit-team-name">
- <i class="svg-icon svg-icon-pencil" data-toggle="modal" data-target="#team-edit-modal" data-modal-action="oncall.team.updateTeamName" data-modal-title="Update Team Info" data-modal-name="{{#if name}}{{name}}{{else}}{{@key}}{{/if}}" data-modal-email="{{email}}" data-modal-slack="{{slack_channel}}" data-modal-slack-notifications="{{slack_channel_notifications}}" data-modal-timezone="{{scheduling_timezone}}" data-modal-irisplan="{{iris_plan}}" data-modal-iris-enabled="{{iris_enabled}}" data-modal-override-phone="{{override_phone_number}}" data-admin-action="true">
+ <i class="svg-icon svg-icon-pencil" data-toggle="modal" data-target="#team-edit-modal" data-modal-action="oncall.team.updateTeamName" data-modal-title="Update Team Info" data-modal-name="{{#if name}}{{name}}{{else}}{{@key}}{{/if}}" data-modal-email="{{email}}" data-modal-slack="{{slack_channel}}" data-modal-slack-notifications="{{slack_channel_notifications}}" data-modal-timezone="{{scheduling_timezone}}" data-modal-irisplan="{{iris_plan}}" data-modal-iris-enabled="{{iris_enabled}}" data-modal-override-phone="{{override_phone_number}}" info-admin-action="true">
  <svg xmlns="http://www.w3.org/2000/svg" width="16px" height="16px" viewBox="0 0 8 8" style="fill: currentColor">
  <path d="M6 0l-1 1 2 2 1-1-2-2zm-2 2l-4 4v2h2l4-4-2-2z" />
  </svg>