Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dexmaker to AGP 8.5 #192

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

prashanthswami
Copy link
Contributor

The intent of this change is to migrate to Android Gradle Plugin 8.5.0, but as a consequence introduces a few other changes:

  • The minimum viable SDK is now 21, as NDK r26 dropped support for 19.
  • The minimum Gradle version is now 8, as AGP 8.5.0 requires it.
  • The minimum JDK version is now 17, as AGP 8.5.0 requires it.
  • The errorprone library was upgraded to provide new JDK classes.
  • The publishing scripts were updated to use the new Gradle properties.
  • Errorprone fixes were applied to the inline-extended classes.

@prashanthswami
Copy link
Contributor Author

Hello! To provide some context for this change - I'm from Google, working on the Android RISC-V project (https://github.com/google/android-riscv64). We recently landed support to build against the RISC-V ABI in the Android NDK (r27), and we're now starting to walk through all the libraries internally that we'd like to produce RISC-V artifacts for - in turn, we're looking at dependencies like dexmaker that AndroidX needs to produce it's own artifacts.

I'd like to file a separate issue to get the maintainer's thoughts on how feasible it would be to publish RISC-V artifacts, but a prerequisite to even consider RISC-V is migrating to an AGP version that supports it. As upgrading AGP versions is orthogonal, I'm hoping we can enable AGP 8.5 with this change and consider RISC-V in a follow up PR.

Copy link
Contributor

@liutikas liutikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

build.gradle Show resolved Hide resolved
Copy link
Contributor

@kkoser kkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay! Changes look good, just want to make sure we have a clear guide for folks adopting this new version in terms of updating our requirements. Thanks for doing this!

dexmaker-mockito/build.gradle Outdated Show resolved Hide resolved
The intent of this change is to migrate to Android Gradle Plugin 8.5.0,
but as a consequence introduces a few other changes:

* The minimum viable SDK is now 21, as NDK r26 dropped support for 19.
* The minimum Gradle version is now 8, as AGP 8.5.0 requires it.
* The minimum JDK version is now 17, as AGP 8.5.0 requires it.
* The errorprone library was upgraded to provide new JDK classes.
* The publishing scripts were updated to use the new Gradle properties.
* Errorprone fixes were applied to the inline-extended classes.
@kkoser kkoser merged commit 1ed459a into linkedin:main Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants