Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use caret range for micromatch dependency #2020

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

monholm
Copy link
Contributor

@monholm monholm commented Aug 29, 2024

Description

4.0.2 contains a vulnerability that most likely doesn't affect @lingui/cli, but there should be no reason to depend on an exact version which prevents consumers from upgrading the package without a version conflict.
I've kept the version at 4.0.2 to prevent a breaking change (in the sense that bumping it to ^4.0.8 might also cause a version conflict for consumers). Let me know if you'd rather bump it to ^4.0.8. Ref: GHSA-952p-6rrq-rcjv

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

4.0.2 contains a vulnerability that most likely doesn't affect @lingui/cli, but there should be no
reason to depend on an exact version which prevents consumers from upgrading the package without a
version conflict.
I've kept the version at 4.0.2 to prevent a breaking change (in the sense that bumping it to ^4.0.8
might also cause a version conflict for consumers). Let me know if you'd rather bump it to ^4.0.8.
Ref: GHSA-952p-6rrq-rcjv
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 8:56am

Copy link

github-actions bot commented Aug 29, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.34%. Comparing base (d6b9698) to head (235cbac).
Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2020      +/-   ##
==========================================
- Coverage   76.65%   75.34%   -1.31%     
==========================================
  Files          81       85       +4     
  Lines        2090     2146      +56     
  Branches      533      547      +14     
==========================================
+ Hits         1602     1617      +15     
- Misses        375      415      +40     
- Partials      113      114       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monholm thank you!

@andrii-bodnar andrii-bodnar merged commit be441e3 into lingui:main Aug 29, 2024
16 checks passed
@monholm monholm deleted the micromatch-dep-cve branch August 29, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants