Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync next to main #1871

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

chore: sync next to main #1871

wants to merge 18 commits into from

Conversation

andrii-bodnar
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 8:04am

@andrii-bodnar andrii-bodnar marked this pull request as draft March 1, 2024 13:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.87 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited

Codecov Report

Attention: Patch coverage is 92.15116% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 77.05%. Comparing base (d6b9698) to head (6bb8983).
Report is 24 commits behind head on main.

❗ Current head 6bb8983 differs from pull request most recent head 4821317

Please upload reports for the commit 4821317 to get more accurate results.

Files Patch % Lines
packages/babel-plugin-lingui-macro/src/macroJs.ts 95.33% 3 Missing and 6 partials ⚠️
packages/cli/src/lingui-extract.ts 0.00% 9 Missing ⚠️
packages/babel-plugin-lingui-macro/src/macroJsx.ts 88.88% 2 Missing and 2 partials ⚠️
packages/vite-plugin/src/index.ts 0.00% 4 Missing ⚠️
packages/babel-plugin-lingui-macro/src/macro.ts 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
+ Coverage   76.65%   77.05%   +0.40%     
==========================================
  Files          81       84       +3     
  Lines        2090     2157      +67     
  Branches      533      555      +22     
==========================================
+ Hits         1602     1662      +60     
- Misses        375      382       +7     
  Partials      113      113

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thekip
refactor(macro): use message descriptor for Trans (#1909)
4821317 
* refactor(macro): use message descriptor for Trans

* update snapshots

* introduce MsgDescriptorPropKey enum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrii-bodnar @thekip @lingui-bot @dan-dr @ninesunsabiu