-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "svg-compressed" to create a simple classic QR Code with compressed file size. Allow execution from a development environment. #342
Open
johnkw
wants to merge
12
commits into
lincolnloop:main
Choose a base branch
from
johnkw:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er savings by removing M cmds.
…rder to avoid the O(n^2)-ish perf hit for splicing a python list repeatedly. Only store spliceable turns, and assert that we dealt with all of them correctly.
Was this actually merged? It says merged here but I don't see it in the commit. |
johnkw
changed the title
Only import png if needed. Add "svg-compressed" to create a simple classic QR Code with compressed file size.
Add "svg-compressed" to create a simple classic QR Code with compressed file size. Allow execution from a development environment.
Sep 28, 2024
Re-merged and complied with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a large code an example original svg is 1479k, svg-path is 286k, and svg-compressed is 59k.
For a small code it's 22k, 3.7k vs 0.8k.