Provide support for custom neuroglancer URL #2
Conversation
✅ Deploy Preview for neuroglancer-lincbrain ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@kabilar just noting -- if we ever want to merge neuroglancer for private assets back upstream, this would be the ideal code we would need to clean up/merge I'm on the fence for prioritizing this right now until we have DANDI clone refined |
|
Thank you, @aaronkanzer. Thats good to know. I agree that we don't need to prioritize merging this upstream to |
| // if (protocol === "https" && path.length > 0) { | ||
| // return await getHtmlPathCompletions( | ||
| // parsedUrl, | ||
| // cancellationToken, | ||
| // credentialsProvider, | ||
| // ); | ||
| // } |
There was a problem hiding this comment.
I lean towards removing commented code.
| // if (protocol === "https" && path.length > 0) { | |
| // return await getHtmlPathCompletions( | |
| // parsedUrl, | |
| // cancellationToken, | |
| // credentialsProvider, | |
| // ); | |
| // } |
| @@ -199,6 +199,7 @@ def get(self, viewer_token, path): | |||
| query = self.request.query | |||
| if query: | |||
| query = f"?{query}" | |||
| # Aaron | |||
| # Default ignored files | ||
| /shelf/ | ||
| /workspace.xml |
There was a problem hiding this comment.
| # Default ignored files | |
| /shelf/ | |
| /workspace.xml | |
| # Default ignored files | |
| /shelf/ | |
| /workspace.xml | |
| .DS_Store |
| # Install project dependencies | ||
| # RUN npm i | ||
|
|
||
| # Vue CLI serves on port 8080 by default, expose that port | ||
| # EXPOSE 8080 | ||
|
|
||
| # Command to run the app using npm | ||
| # CMD ["npm", "run", "dev-server"] |
There was a problem hiding this comment.
Should we remove these commands?
There was a problem hiding this comment.
Thanks @aaronkanzer. I provided a few suggestions, but I don't know enough TypeScript to provide a thorough review.
|
@kabilar -- thanks for the review -- after re-reading my code here, I think I might hold off on merging this until we have MIT storage onboard (e.g. the way that we fetch assets from Engaging might be drastically different) Considering our neuroglancer instance is stable, I figured punting this for now would be alright -- let me know if you'd like me to close |
No description provided.