Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instance name from dandi to lincbrain #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kabilar
Copy link
Member

@kabilar kabilar commented Aug 7, 2024

With DANDI Archive there are several resource identifiers which can be used to download an asset and/or Dandiset. For the --preserve-tree option to work ideally, we need to use the resource identifier shown in the command below (or a similar variant that contains the instance name). However, I receive an error when running the command below with version 0.11.1.

Command

lincbrain download --preserve-tree dandi://LINCBRAIN/000724@draft/derivatives/dwi/sub-I58/sub-I58_sample-blockIC1_desc-preproc_dwi.bvals

Error

2024-08-07 11:14:37,968 [    INFO] Logs saved in /Users/kabilar/Library/Logs/lincbrain-cli/2024.08.07-16.14.37Z-98568.log
Error: Unknown instance 'lincbrain'.  Valid instances: dandi, dandi-api-local-docker-tests, lincbrain-staging

Should we also update or disable the other URL patterns in _dandi_url_parser that contain DANDI:?

Thank you.

@aaronkanzer
Copy link

@kabilar sorry I never got back to review this -- looking now

Before fully reviewing, wanted to ask regarding your question in the description: Should we also update or disable the other URL patterns in [_dandi_url_parser](https://github.com/lincbrain/linc-cli/blob/d682859bc5685217fbca5dd64525fe4189411d91/lincbrain/dandiarchive.py#L566) that contain DANDI:

I believe that schema validation fails if DANDI: prefix is not there -- this might be something that we'd need to consult with Yarik and John Wodder for de-coupling for clones prior to attempting a fix here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants