Merge pull request #141 from lilt/4.x-fix-translations

Hotfix connector translation ids
lilt · Jan 30, 2024 · c88afc9 · c88afc9
2 parents 2449f97 + 94ea19d
commit c88afc9
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## 4.4.3 - 2023-11-15
+### Changed
+- Change translation limit for get translation request 
+
 ## 4.4.2 - 2023-11-15
 ### Fixed
 - Lock release issue after queue message processing

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
   "name": "lilt/craft-lilt-plugin",
   "description": "The Lilt plugin makes it easy for you to send content to Lilt for translation right from within Craft CMS.",
   "type": "craft-plugin",
-  "version": "4.4.2",
+  "version": "4.4.3",
   "keywords": [
     "craft",
     "cms",

diff --git a/e2e/cypress/support/flow/instant.js b/e2e/cypress/support/flow/instant.js
@@ -109,15 +109,15 @@ Cypress.Commands.add('instantFlow', ({
             'name': 'Authorization', 'values': ['Bearer this_is_apy_key'],
           }], 'queryStringParameters': [
           {
-            'name': 'limit', 'values': ['100'],
+            'name': 'limit', 'values': ['1000'],
           }, {
             'name': 'start', 'values': ['00'],
           }, {
             'name': 'job_id', 'values': ['777'],
           }],
       }, 'httpResponse': {
         'statusCode': 200, 'body': JSON.stringify({
-          'limit': 100, 'start': 0, 'results': translationsResult,
+          'limit': 1000, 'start': 0, 'results': translationsResult,
         }),
       }, 'times': {
         'unlimited': true,

diff --git a/e2e/cypress/support/flow/verified.js b/e2e/cypress/support/flow/verified.js
@@ -109,15 +109,15 @@ Cypress.Commands.add('verifiedFlow', ({
             'name': 'Authorization', 'values': ['Bearer this_is_apy_key'],
           }], 'queryStringParameters': [
           {
-            'name': 'limit', 'values': ['100'],
+            'name': 'limit', 'values': ['1000'],
           }, {
             'name': 'start', 'values': ['00'],
           }, {
             'name': 'job_id', 'values': ['777'],
           }],
       }, 'httpResponse': {
         'statusCode': 200, 'body': JSON.stringify({
-          'limit': 100, 'start': 0, 'results': translationsResult,
+          'limit': 1000, 'start': 0, 'results': translationsResult,
         }),
       }, 'times': {
         'unlimited': true,

diff --git a/src/services/repositories/external/ConnectorTranslationRepository.php b/src/services/repositories/external/ConnectorTranslationRepository.php
@@ -32,7 +32,7 @@ public function findByJobId(int $jobId): ConnectorTranslationsResponse
         }
 
         $response = $this->apiInstance->servicesApiDeliveriesGetDeliveriesByJobId(
-            100,
+            1000,
             "00",
             $jobId
         );

diff --git a/tests/integration/controllers/job/GetSyncFromLiltControllerCest.php b/tests/integration/controllers/job/GetSyncFromLiltControllerCest.php
@@ -121,7 +121,7 @@ public function testSyncSuccess(IntegrationTester $I): void
         $I->expectTranslationsGetRequest(
             777,
             0,
-            100,
+            1000,
             HttpCode::OK,
             $responseBody
         );

diff --git a/tests/integration/modules/FetchJobStatusFromConnectorCest.php b/tests/integration/modules/FetchJobStatusFromConnectorCest.php
@@ -109,7 +109,7 @@ public function testExecuteSuccessVerified(IntegrationTester $I): void
         $I->expectTranslationsGetRequest(
             777,
             0,
-            100,
+            1000,
             HttpCode::OK,
             $responseBody
         );
@@ -240,7 +240,7 @@ public function testExecuteSuccessInstant(IntegrationTester $I): void
         $I->expectTranslationsGetRequest(
             777,
             0,
-            100,
+            1000,
             HttpCode::OK,
             $responseBody
         );

diff --git a/tests/integration/modules/FetchTranslationFromConnectorCest.php b/tests/integration/modules/FetchTranslationFromConnectorCest.php
@@ -99,7 +99,7 @@ public function testExecuteInstantSuccess(IntegrationTester $I): void
         $I->expectTranslationsGetRequest(
             777,
             0,
-            100,
+            1000,
             HttpCode::OK,
             $translationsResponseBody
         );
@@ -241,7 +241,7 @@ public function testExecuteVerifiedSuccess(IntegrationTester $I): void
         $I->expectTranslationsGetRequest(
             777,
             0,
-            100,
+            1000,
             HttpCode::OK,
             $translationsResponseBody
         );