Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete user #69

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Delete user #69

merged 3 commits into from
Oct 5, 2023

Conversation

jho44
Copy link
Collaborator

@jho44 jho44 commented Oct 1, 2023

enable deleting user

@jho44 jho44 requested a review from lilith October 1, 2023 09:21
@lilith
Copy link
Owner

lilith commented Oct 1, 2023

But if one adult creates a household, adds another adult, and that adult deletes their account then the household is deleted too. Thus we planned to have a flow where you don't delete the household unless you're the last adult

@jho44
Copy link
Collaborator Author

jho44 commented Oct 1, 2023

But if one adult creates a household, adds another adult, and that adult deletes their account then the household is deleted too. Thus we planned to have a flow where you don't delete the household unless you're the last adult

Ah yes...that is perfectly reasonable. Just added that logic and changed the wording of the confirmation modal

@lilith lilith merged commit 94e5f3c into main Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilith lilith lilith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jho44 @lilith